rebuild fixed?

[kulmegil_]

I just noticed that "[Bug 576] /rebuild is broken" got a "solved" status... but is it?
I builded recent DC++ CVS and imported my older filelist (~800GB, lots of old trash in database). So far OK.
/rebuild did quite a good job and shrinked my hashindex.xml over 5 times... however after refresh it appeared that it cleaned out most of the good stuff leaving only 30GB of hashed data :/
It’s a bug or older filelists are not 100% compatibile with recent builds then…?

Wouldn’t it be a good idea to sort all files when rebuild to speed up filelist loading/refresh later? (I don’t know if such thing really helps in DC++)


/sorry for bad english/

/why my prev. account, "Kulmegil", isn't active anylonger?/

[GargoyleMT]

It’s a bug or older filelists are not 100% compatibile with recent builds then…?

Presumably a bug, from the way you describe it. Perhaps even fixed, depending on when you did your CVS checkout.

/why my prev. account, "Kulmegil", isn't active anylonger?/

You've never posted using that account, so I don't see any evidence that it was ever active.

[kulmegil_]

it's not fixed in 0.68
I tested with new filelist "builded" in DC++ 0.68

I noticed that rebuild only leaves small files on list,
that is TTH trees only starting with

Code: Select all

<Hash Type="TTH" Index="-1" BlockSize="65536" (...)

maybe it's something specific to my system (some strange filename somewhere). I can provide hashindex before/after rebuild if needed.
Anyway I wish this really gets fixed at last...

[GargoyleMT]

From what I've seen, /rebuild is fixed in 0.68. Having your share "rebuilt" (refreshed) is not the same thing as what "/rebuild" does, which is to compact your hash database.

If you're not seeing larger files in your share, it sounds like they're simply not hashed yet. Do you see any files that are being hashed in your system log?

[kulmegil_]

....I know what refresh do and it works the way is shuld....

I suppose that what /rebuild does is clean all useless entries from hash database. The same as if I would delete old HashIndex.xml and wait for my DC++ to rehash all files from scratch (except it takes a lot longer).


If above is correct then /rebuild doesn't do what it's supposed to for me - because 99% of my good hashes are deleted from database (there is no difference if I would delete entire database and wait for all files to hash again).

[GargoyleMT]

If above is correct then /rebuild doesn't do what it's supposed to for me - because 99% of my good hashes are deleted from database (there is no difference if I would delete entire database and wait for all files to hash again).

It works for me, but I'll test it on my other share as well.

I presume, then, that the system log does show files being rehashed?

Once its done, see if /rebuild deletes those hashes again. If they're not valid (i.e. they've been corrupted), DC++ is right in removing them and forcing a rehash.