CVS todo list?

[GargoyleMT]

Here's my list of stuff that seems to amiss in CVS:

* The "hub name" seems inconsistent; it copies two words for "DCDev Private", but only one for another hub I'm on "VGMC Pocket" (ah, there's much more after "Private", but with "Pocket", it's the end of the string
* "Your" nick in PM seems to be using the one from Settings instead of the Favorite Hubs
* "Last Seen" in the Favorite User Manager is never set, seemingly
* Favorite Users aren't updated as you quit/join hubs (maybe when they go offline and online again)
* I got 4 blank user names in the Favorite User window when I restarted DC++. One of the missing users was me, though I'm not sure who the other 3 were.
* Remove in favorites is still broken because it doesn't iterate from the beginning each time.
* your tag still reads "P"
* "Go to directory" in ADLSearch results seems to have been broken again in 0.674
* "Match Queue" button in 0.674 seems to be disabled

Additions welcome... I just don't want a release where we'll have support issues right off the bat.

[Pothead]

Socket Exception: Connection closed (debug mode, Connection Closed in Release mode), when trying to get a filelist of an older client should be fixed i think, if you wanna minimize support issues.

[GargoyleMT]

Old file list? Odd. There's probably still a $UGetBlock disconnection issue around somewhere too.

Do you have any more details about how to reproduce it, or should it be pretty obvious?

[joakim_tosteberg]

I made som quick tests on it and it seems to alawys hapen when downloading filelists from version 0.401 of DC++ and probably 0.402 as well but there was only one person using that client during my test. Version 0.403 seems to work fine.

[GargoyleMT]

I made som quick tests on it and it seems to alawys hapen when downloading filelists from version 0.401 of DC++ and probably 0.402 as well but there was only one person using that client during my test. Version 0.403 seems to work fine.

That might be the $UGetBlock thing. I don't think it being fixed is in the changelog (I'll probably patch that in), but 0.402 sounds about right.

[ullner]

'0.05' in Max upload speed is there twice. And in PublicHublistDlg.h;

Code: Select all

         LineDlg hublist;
         hublist.title = _T("Hublist");
         hublist.description = _T("Edit the hublist");

[GargoyleMT]

'0.05' in Max upload speed is there twice. And in PublicHublistDlg.h;

Ah, non-localized strings. And the first 0.05 should be 0.005, probably.

[ullner]

When logging in as operator in a hub, the "operator part" of the tag isn't updated. The "registered-part" is though. (I don't know a better way to explain it... Just log into a hub as operator and look at your tag.)

[GargoyleMT]

It seems to be updated eventually. Perhaps this is an artifact of the changes to the sending of myinfo?

[GargoyleMT]

Another:
* Reconnecting on ADC hubs... doesn't work. presumably the state needs to be reset, and because it's not the login breaks.

[ullner]

You mean automatic reconnect or manual reconnect? (The latter work fine here.)

By the way, NI and DE coming from the hub doesn't show in the hubframe. (ADC)

Further: people quitting doesn't seem to be updated in the user list. (ADC)

[GargoyleMT]

Manual, but cologic says it works for him, so I must be missing a CVS update or have otherwise broken it.

[ullner]

Connection type is never displayed in the user list.

[ullner]

* The client CID change after each startup.

[cologic]

Some wouldn't regard that as a bug...

[Big Muscle]

* Identity class isn't thread-safe. Two threads can access to "info" map which can result in crash in Identity::get/set

I think it's connected with these crashes:
http://dcpp.net/crash/view_crash.php?id=10279
http://dcpp.net/crash/view_crash.php?id=10276
http://dcpp.net/crash/view_crash.php?id=10277