0.34

Post by **arnetheduck** » 2004-12-28 19:40

Ok, here's hopefully the final version of dch++ that will be released. I do not intend to add any more features to it anyway, and will only fix serious bugs. The plan is to move dch++ to ADC after the initial 1.0 release, and not support nmdc any more. Together with the hub comes also the plugin API, so you may have a look at it and if you know how to code, make your own plugins. Because of heavy changes to how the linux version is built and installed, there will be no more binaries, and as soon as I find sed, I'll tell him to open up public access to the svn so you may get the source and compile it for yourselves (please note; dch++ is not opensource as the official definition goes, please see license.txt).
I do not care particularily for the nmdc version of dch++ to spread, but since the work has already been done, I'll release it anyway as some might like it anyway.

http://wza.digitalbrains.com/users/.arn ... -Win32.rar
http://wza.digitalbrains.com/users/.arn ... Config.rar
http://wza.digitalbrains.com/users/.arn ... 34-API.rar

CioDu · Post by **CioDu** » 2004-12-29 13:57

Code: Select all

5) If you have the Plugin API, you may distribute the plugins that you make. The source must be made available
   together with any published binaries, and must be just as easily accessible as the binaries. If you choose
   not to distribute your plugins, you may also keep your source code.

I guess the choice of the license for the plugins is up to the plugin writer? redistribution of the core not allowed should mean that plugins cannot be licensed under GPL, right? perhaps LGPL?

Post by **arnetheduck** » 2004-12-29 14:20

hm, gpl with an exception is probably fine (that's what dc++ does with the wtl for instance)...actually I don't care really what license you choose, I intend for the nmdc version of dch++ die a somewhat fast death anyway, which is why I put the rather restrictive license on it...

Post by **GargoyleMT** » 2004-12-29 17:36

GPLing plugins to non-GPL works is covered in this FAQ: http://www.fsf.org/licenses/gpl-faq.html#GPLPluginsInNF

Can I use the GPL for a plug-in for a non-free program?
If the program uses fork and exec to invoke plug-ins, then the plug-ins are separate programs, so the license for the main program makes no requirements for them. So you can use the GPL for a plug-in, and there are no special requirements.

If the program dynamically links plug-ins, and they make function calls to each other and share data structures, we believe they form a single program, so plug-ins must be treated as extensions to the main program. This means that linking the GPL-covered plug-in with the main program would violate the GPL. However, you can resolve that legal problem by adding an exception to your program's license which gives permission to link it with the non-free main program.

For more details, see the question above that starts with, "I am writing free software that uses a non-free library."

So, the plugin author needs to add the exception that linking to DCH++ is fine. DCH++ doesn't need to do anything.

Sedulus · Post by **Sedulus** » 2005-01-02 18:36

anonymous svn is open now
http://dchpp.digitalbrains.com/

yakko · Post by **yakko** » 2005-01-02 19:27

I've gotten the source downloaded and am about to try compiling it now. Is the -prefix line in the configure script where "make install" will try to install the binaries?

yakko · Post by **yakko** » 2005-01-03 01:33

OK, it all compiled fine. Here's the notes and problems I've got for the linux version:

1) to compile I did the following:
I wrote a little shell script to get all the sources:

Code: Select all

cd ~/src
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/core/dchpp-1.0
cd dchpp-1.0/plugins
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/OpCom
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/SimpleLog
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/BigBrother
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/BlockLeechers
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/CrappyOs
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/DnsBl
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/HubRules
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/IpCheck
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/IpSecurity
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/LuaScript
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/Motd
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/NoBots
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/Restrictions
svn checkout svn://dchpp.digitalbrains.com/p2p/dchpp/plugins/UserIp

I then chmod'd the file and ran it, then did this:

Code: Select all

./bootstrap
cd build
../configure --enable-plugins --prefix $HOME/src/
make && make install

I then made a /usr/local/bin/dchpp-1.0 to put it in and not bother my current hub, copied ~/src/bin/dchpp to it and ~/src/bin/lib/dchpp/ to /usr/local/bin/dchpp-1.0/plugins. That part of the INSTALL doc could be a little better documented.

2) the plugin .xml and readme files stayed the plugin source directories. This needs to be documented and it'd be great if they could be moved into a etc directory on the "make install" step.

3) all the plugins work great except for the LuaScript one. When it's enabled I get this error and the hub dies:

Code: Select all

yakko@cybertron dchpp-1.0 $ ./dchpp -c /etc/dchpp/iaconhub-1.0/
./dchpp: symbol lookup error: /usr/local/bin/dchpp-1.0/plugins/LuaScript.so: undefined symbol: lua_open

I can start the hub fine without loading that plugin.

Post by **arnetheduck** » 2005-01-03 10:05

the whole point with make install is that it installs everything in the final position, you're not supposed to copy anything. if you remove your src, most probably things will stop working since it's compiled with static paths to the libdchpp.so that does all the work...
as to the lua, I'll have a look...

yakko · Post by **yakko** » 2005-01-03 16:13

I was afraid to do the make install to my real path because I didn't want to overwrite my existing hub directory. I can try it again with my testing path.

Post by **arnetheduck** » 2005-01-06 12:31

update luascript and try again...
you don't have to make install to your real path - that's what --prefix is for...--help will tell you exactly where things get installed...

Sedulus · Post by **Sedulus** » 2005-01-06 12:38

a working but incorrect fix is:

Code: Select all

Index: Makefile.am
===================================================================
--- Makefile.am (revision 11)
+++ Makefile.am (working copy)
@@ -3,7 +3,7 @@
 plugin_LTLIBRARIES=LuaScript.la

 LuaScript_la_LDFLAGS = -module -avoid-version
-
+LuaScript_la_LIBADD = ../lua/src/liblua.a
 LuaScript_la_SOURCES=\
 LuaClient.cpp \
 LuaClient.h \

Post by **arnetheduck** » 2005-01-06 12:55

I was first =)

you have to add -fPIC to the lua source files on amd64 as well, my patch does that...
technically, it would probably be better to have lua as a prerequisite on linux, and use the system provided one...on the other hand, linking statically avoids all version problems...hmm...

Sedulus · Post by **Sedulus** » 2005-01-06 13:34

I was half an hour earlier in dcdev ;)

DC++

0.34

0.34

Who is online