"Max upload speed"

Pothead · Post by **Pothead** » 2006-01-20 13:27

This seems to be causing confusion amongst some people who think this is an actual upload limiter . . . :roll:

Would it be better to replace this:
SETTINGS_UPLOAD_SPEED, // "Max upload speed"

with:
SETTINGS_UPLOAD_SPEED, // "Line speed (upload)"

or sommit like that to make it easier to understand. :?:

Post by **GargoyleMT** » 2006-01-20 17:12

That seems sane to me.

Pothead · Post by **Pothead** » 2006-01-29 15:03

For changing this, should i only change the StringDef, or also the Strigdef call (SETTINGS_UPLOAD_SPEED) and the IDC controls ?

Quattro · Post by **Quattro** » 2006-01-29 15:07

you can't figure that out on yourself? ;-)

=)

Post by **ullner** » 2006-01-29 15:15

If you just want to change what DC++ display - The StringDef.

Pothead · Post by **Pothead** » 2006-01-29 16:09

Yes, i just meant should i change the other things which are related to this as well. E.g.
IDC_SETTING_MAX_UPLOAD to IDC_SETTING_LINE_SPEED
to make it easier to follow. I was originally thinking of just the stringdef change, but that makes the rest look untidy.

Post by **GargoyleMT** » 2006-01-30 17:02

Pothead wrote:Yes, i just meant should i change the other things which are related to this as well. E.g.
IDC_SETTING_MAX_UPLOAD to IDC_SETTING_LINE_SPEED
to make it easier to follow. I was originally thinking of just the stringdef change, but that makes the rest look untidy.

Your gut instinct is right. Make the change everywhere it makes sense (this is why I've started using the idc_* as the label for text items in the resource editor, so I don't have to change that string as well.)

Pothead · Post by **Pothead** » 2006-01-30 19:19

http://dcpp.net/bugzilla/show_bug.cgi?id=815

Thank you for the advice.

"Max upload speed"

"Max upload speed"

Who is online