DC++ 0.22 - "User command" bugfix

[MyKee]

There is a bug "User Menu items". It works great as long as you send the commands to the main chat, but If you specify that you want the command to be sent as a PM to a user you keep getting disconnected when choosing the user command.

After looking in the source I've found that changing the code

Code: Select all

HubFrame.cpp - Line: 871,
client->privateMessage(u->user, Util::formatParams(uc.getCommand(), sm));

to

Code: Select all

string s = "<" + client->getNick() + "> ";
client->privateMessage(u->user, s + Util::formatParams(uc.getCommand(), sm));

Works great.

It seems like when sending the PM it does not include the username so the client disconnects.
I would be great if some developer with write access could fix this, but otherwise DC++ is a great program. Keep the good work up.

Thanks, MyKee

[Djurmamman]

Arne is aware if that and has said he will fix it in the next version.

[TMM]

that bug fix dont work for me

[MyKee]

that bug fix dont work for me

hmm, so I noticed
It sends the messages to the person you select in the userlist even if you has choosen that the message should go to someone else ... sorry, buggy patch

[Superbeast]

In 0.23 it works halfway but my scripts can't handle it
When I use the commands the client sends:
$To: [reciver] From: [sender] $[command]
But my scripts wants it in the same way as usual private message:
$To: [reciver] From: [sender] $<[sender]>[command]
So I shanged

Code: Select all

client->privateMessage(uc.getNick(), Util::formatParams(uc.getCommand(), sm));

To:

Code: Select all

client->privateMessage(uc.getNick(), "<" + client->getNick() + ">" + Util::formatParams(uc.getCommand(), sm));

Almost like the trick in the top
And this works

[NattensQje]

In 0.23 it works halfway but my scripts can't handle it
When I use the commands the client sends:
$To: [reciver] From: [sender] $[command]
But my scripts wants it in the same way as usual private message:
$To: [reciver] From: [sender] $<[sender]>[command]
So I shanged

Code: Select all

client->privateMessage(uc.getNick(), Util::formatParams(uc.getCommand(), sm));

To:

Code: Select all

client->privateMessage(uc.getNick(), "<" + client->getNick() + ">" + Util::formatParams(uc.getCommand(), sm));

Almost like the trick in the top
And this works

That bug fix don't work for me eather..

[Superbeast]

Hmm, seems like I missed a space in ">", it should be like this "> ".
If you have done it like this when the client sends it exacly as if it was a private message.

[FRANKE]

In 0.23 it works halfway but my scripts can't handle it
When I use the commands the client sends:
$To: [reciver] From: [sender] $[command]
But my scripts wants it in the same way as usual private message:
$To: [reciver] From: [sender] $<[sender]>[command]
So I shanged

Code: Select all

client->privateMessage(uc.getNick(), Util::formatParams(uc.getCommand(), sm));

To:

Code: Select all

client->privateMessage(uc.getNick(), "<" + client->getNick() + ">" + Util::formatParams(uc.getCommand(), sm));

Almost like the trick in the top
And this works

Lets say you want to use the command "userinfo", then create a menu with this info:

Name: Userinfo
Command: <%[mynick]>userinfo %[nick]
Hub ip/Dns: op
PM To: BotName